Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow intercept of touch event by adding option in SKTouchEventArgs #1096

Closed
wants to merge 2 commits into from

Conversation

mackel90
Copy link

Description of Change

Updated "SKTouchEventArgs" so it contains boolean "RequestDisallowIntercept" which will call the equal function in Androids SKTouchHandler to enable more control for the user like the solution of @FoggyFinder in #953

Tests made but hang after "SkiaSharp.Tests.SKCodecTest.ReadOnlyStream [FINISHED] Time: 0,0163149s"

Bugs Fixed

API Changes

List all API changes here (or just put None), example:

Added:

  • bool SkiaSharp.Views.Forms.SKTouchEventArgs.RequestDisallowIntercept { get; set; }

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@msftclas
Copy link

msftclas commented Jan 10, 2020

CLA assistant check
All CLA requirements met.

@xpios01
Copy link

xpios01 commented Jan 21, 2021

I don't see this in the current main branch. When is this going to make it in or was there a different fix added somewhere? I need to be able to prevent the scrollview from taking over touch events when I'm dragging an object on a surface within the scrollview.

thanks.

Base automatically changed from master to main February 5, 2021 08:30
@mackel90 mackel90 closed this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants